Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display of estimated pending rewards amounts #8852

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented May 18, 2021

Resolves brave/brave-browser#15005

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

UI:

NTP widget:

Screen Shot 2021-05-19 at 10 02 44 AM

Rewards page:

Screen Shot 2021-05-19 at 10 03 35 AM

Rewards page (Android):

Screen Shot 2021-05-19 at 10 08 33 AM

Scenario: NTP Widget

  • Given that the current day-of-month is less than the day-of-month of the next Ads payment date
  • And the user's pending Ads earnings amount for the previous is greater than zero
  • When the user visits the new tab page
  • Then they should see a message in the Rewards widget indicating the amount of earnings from the previous month and the number of days until the next payment date
  • And the estimated current earnings value should not include earnings from the previous month.

Scenario: Rewards Page

  • Given that the current day-of-month is less than the day-of-month of the next Ads payment date
  • And the user's pending Ads earnings amount for the previous is greater than zero
  • When the user visits the rewards page
  • Then they should see a message in the Ads box indicating the amount of earnings from the previous month and the number of days until the next payment date
  • And the estimated current earnings value should not include earnings from the previous month.

@zenparsing zenparsing changed the title Modify pending rewards amounts Update display of estimated pending rewards amounts May 19, 2021
@zenparsing zenparsing force-pushed the ksmith-ads-pending-rewards branch 2 times, most recently from c15bf20 to cbbae78 Compare May 19, 2021 14:10
@zenparsing zenparsing marked this pull request as ready for review May 19, 2021 19:09
@zenparsing zenparsing requested a review from a team as a code owner May 19, 2021 19:09
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would just suggest testing with an old profile (if you haven't already) to make sure the type changes don't cause unexpected backwards-compatibility problems.

@zenparsing zenparsing requested a review from tmancey May 20, 2021 19:35
@zenparsing zenparsing force-pushed the ksmith-ads-pending-rewards branch 3 times, most recently from 02ae93c to c998c5b Compare May 24, 2021 20:47
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@zenparsing zenparsing force-pushed the ksmith-ads-pending-rewards branch 2 times, most recently from 2448c7b to 87eee97 Compare June 2, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimated pending rewards should reset monthly
3 participants